envoyproxy / envoyproxy/envoy

test framework: set default concurrency, and make concurrency an explicit option in integration test framework

Open
#24,246 2 comments 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: test framework: set default concurrency, and make concurrency an explicit option in integration test framework

*Description*:
Envoy by default starts a worker for every hardware thread,
https://blog.envoyproxy.io/envoy-threading-model-a8d44b922310

for tests run on a beefy machine, this usually means either 64/72 or even 128 workers are started in an integration test.

I am not sure so many workers are desired, which may even cause noise in test.
I think we should make it an explicit option to let each integration test to pick how many workers are started, and set the default to 1 or 2 if multiple workers are not desired for the test.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.