envoyproxy / envoyproxy/envoy

redis outlier detection when redis is down but Envoy is up

Open
#24,215 12 comments 0 reactions 0 assignees View on GitHub
area/outlier_detection area/redis help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

In the current implementation , when server Envoy is up but redis down, we send proper error response with "UpstreamFailure" - as a result of the this Client Envoy does not detect this as outlier and eject even when outlier detection is enabled on client side.

So in cases where redis container is down but Envoy is up - Should n't this failure treated as outlier from client side (similar to 503 in http)?

Or are there any reasons why this has been implemented like this?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.