Envoy should NACK an EDS update with duplicate addresses
Open
area/eds
bug
help wanted
- Dominant language
- C++
- Stars
- 28.9k
- Forks
- 5.6k
- Avg merge
- 1d 22h
- Merged PRs (30d)
- 430
Description
Currently, if there are multiple addresses in the same EDS resource, Envoy will [ignore all but the first occurrance](https://github.com/envoyproxy/envoy/blob/df5152b6d46bcc16c526837069cf749f9621d0d9/source/common/upstream/eds.cc#L136). This behavior seems fairly arbitrary and surprising, especially because the different occurrances of the address could be in different localities or priorities.
I think in this case, Envoy should NACK the EDS update.
CC @kyessenov
Contributor guide
Assessment
This issue has not been assessed yet.