envoyproxy / envoyproxy/envoy

uhv: support JSON-encoded URLs for gRPC requests

Open
#23,291 6 comments 0 reactions 0 assignees View on GitHub
area/header_validator enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: uhv: support JSON-encoded URLs for gRPC requests

*Description*:
gRPC may JSON encoded data within the URL query parameter. UHV follows RFC guidance for URL and path validation, which would reject valid JSON encoded query parameters. For example:

- **UHV Allowed:** `/shelf?shelf.search%5Bdecoded%5D=Google`
- **UHV Rejected:** `/shelf?shelf.search[decoded]=Google`

See test `GrpcJsonTranscoderIntegrationTest / QueryParamsDecodedName` for this example.

Ideally UHV supports and correctly validates these gRPC style requests.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.