envoyproxy / envoyproxy/envoy

Check non-RBE proto_format timing

Open
#22,483 2 comments 0 reactions 0 assignees View on GitHub
bug investigate no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

In #21750 #21769 and #21754 various optimizations were made to proto_format

these optimizations were mostly focused on the RBE use case as that is what is used in CI and most core devs have it available. They were also focused on optimizing the incremental use case (at least for protos that are not depended upon by other protos)

its not clear exactly the impact on the non-RBE case - esp where core protos have been changed

for now the workaround is to use CI to run proto_format and generate any required diffs

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.