envoyproxy / envoyproxy/envoy

Test examples incrementally

Open
#21,935 3 comments 0 reactions 1 assignee Claimed by @phlax View on GitHub
area/examples enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

currently we test all examples every time and do so outside of bazel

its not really possible (or at least not easy) to make the examples truly hermetic - mostly because they rely on system docker - if we were to switch to `rules_docker` they would still need to parse/translate the `docker-compose` instructions into docker rules

we can however make it almost hermetic - by using a bazel sourced docker-compose, using the required files as inputs and setting an action_env that set the container hash to use for envoy

potentially this can take a massive load off ci as well as making it faster, and also making it easier to (incrementally) test examples locally

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.