envoyproxy / envoyproxy/envoy

Sanity checks on dummy configs for integration tests

Open
#20,275 5 comments 0 reactions 0 assignees View on GitHub
area/quic enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

This issue was discovered in #20259 which used MockClusterInfo for HTTP integration tests.

However the default value of the connect timeout would cause Quiche to complain and crash at [QuicConnection::SetNetworkTimeouts](https://github.com/google/quiche/blob/main/quic/core/quic_connection.cc#L4632).

I think default value like this doesn't make much sense.
I wonder if more of such cases exist in Envoy's integration test setups.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.