envoyproxy / envoyproxy/envoy

Flake: AccessLogManagerImplTest.ReopenRetry

Open
#19,995 2 comments 0 reactions 1 assignee Claimed by @nezdolik View on GitHub
area/test flakes help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

Flake: AccessLogManagerImplTest.ReopenRetry

*Description*:
has flakes under code coverage with runs in CI for the following PRs: [19914](https://dev.azure.com/cncf/envoy/_build/results?buildId=101636&view=results), [19962](https://dev.azure.com/cncf/envoy/_build/results?buildId=101582&view=results), [19777](https://dev.azure.com/cncf/envoy/_build/results?buildId=101671&view=results)

Running it with coverage locally:

```
[06:55:04] kbaichoo:envoy:0 $bazel test --config=coverage //test/common/access_log:access_log_manager_impl_test --runs_per_test=1000 --test_filter="*ReopenRetry*"
INFO: Analyzed target //test/common/access_log:access_log_manager_impl_test (0 packages loaded, 227 targets configured).
INFO: Found 1 test target...

bazel-bin/test/common/access_log/access_log_manager_impl_test
INFO: Elapsed time: 1305.064s, Critical Path: 177.43s
INFO: 1003 processes: 2 internal, 1001 linux-sandbox.
INFO: Build completed, 1 test FAILED, 1003 total actions
//test/common/access_log:access_log_manager_impl_test FAILED in 61 out of 1000 in 166.9s
Stats over 1000 runs: max = 166.9s, min = 5.5s, avg = 120.4s, dev = 25.5s
```

Flake seems related with https://github.com/envoyproxy/envoy/pull/19714

```
[07:37:55] kbaichoo:envoy:0 $cat /usr/local/google/home/kbaichoo/.cache/bazel/_bazel_kbaichoo/75388abe3eaf73a64e5fc0563befa9b7/execroot/envoy/bazel-out/k8-fastbuild/testlogs/test/common/access_log/access_log_manager_impl_test/run_997_of_1000/test.log
exec ${PAGER:-/usr/bin/less} "$0" || exit 1
Executing tests from //test/common/access_log:access_log_manager_impl_test
-----------------------------------------------------------------------------
Note: Google Test filter = *ReopenRetry*
[==========] Running 1 test from 1 test suite.
[----------] Global test environment set-up.
[----------] 1 test from AccessLogManagerImplTest
[ RUN ] AccessLogManagerImplTest.ReopenRetry
test/common/access_log/access_log_manager_impl_test.cc:447: Failure
Expected equality of these values:
0UL
Which is: 0
store_.gauge("filesystem.write_total_buffered", Stats::Gauge::ImportMode::Accumulate) .value()
Which is: 12
Stack trace:
0x88a4e0: Envoy::AccessLog::(anonymous namespace)::AccessLogManagerImplTest_ReopenRetry_Test::TestBody()
0x7f3968a026dd: testing::internal::HandleSehExceptionsInMethodIfSupported<>()
0x7f39689e97c1: testing::internal::HandleExceptionsInMethodIfSupported<>()
0x7f39689cd34d: testing::Test::Run()
0x7f39689ce0a4: testing::TestInfo::Run()
... Google Test internal frames ...

[ FAILED ] AccessLogManagerImplTest.ReopenRetry (25 ms)
[----------] 1 test from AccessLogManagerImplTest (25 ms total)

[----------] Global test environment tear-down
[==========] 1 test from 1 test suite ran. (25 ms total)
[ PASSED ] 0 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] AccessLogManagerImplTest.ReopenRetry
```

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.