envoyproxy / envoyproxy/envoy

uhv: codec honor legacy header validation configuration

Open
#19,755 1 comment 0 reactions 0 assignees View on GitHub
area/http enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

As part of the unified header validation component, each HTTP codec will need to honor the header validation policy configuration and use the legacy parsing/validation when the policy is configured. Each codec will need to be updated to check the configured policy and either use or skip the legacy validations. Additionally, the policy will determine how the underlying library is configured (see #19750 and #19751).

For example, the [h1 codec](https://github.com/envoyproxy/envoy-setec/blob/11627cb0bd1d77b18382205682a78d245c132b55/source/common/http/http1/codec_impl.cc#L678) will need to check the validation policy when parsing header values and only validate the header value when operating in legacy mode.

This will need to be completed after the HCM configuration is updated to include the header validation policy, #19754.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.