envoyproxy / envoyproxy/envoy

Clean up PANIC macros

Open
#19,229 12 comments 0 reactions 0 assignees View on GitHub
beginner enhancement help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

https://github.com/envoyproxy/envoy/pull/19204 replaced NOT_REACHED_GCOVR_EXCL_LINE macros with more clear PANIC_DUE_TO_CORRUPT_ENUM macros.

While more clear, the panics are still suboptimal becasue doing break; instead of return; results in production crashes. These should be cleaned up and replaced with sensible defaults on a case by case basis.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.