envoyproxy / envoyproxy/envoy

quic: measure GRO performance and enable it via config

Open
#19,119 0 comments 0 reactions 0 assignees View on GitHub
area/perf area/quic area/udp help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

UDP GRO is supposed to improve socket read performance on client side but currently our code performs very poorly in nighthawk client, by reading one packet per read while allocating 24k buffer. It will be worthwhile to invest the suitable traffic patten for GRO.
Meanwhile this feature is disabled in https://github.com/envoyproxy/envoy/pull/19088 and it will be good to exposed it via a config knob after we know the suitable use case.

And there was a bug reported that the socket reading code allocating 24k buffer per read might lead to MSG_TRUNC and cause packets dropped occasionally. We should change the value to be 64k which is the max GRO receive buffer allowed by the kernel.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.