envoyproxy / envoyproxy/envoy

quic: Add crash dump support

Open
#19,068 6 comments 0 reactions 1 assignee Claimed by @YaoZengzeng View on GitHub
area/quic enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

quic: Add crash dump support

*Description*:
H1, H2 codecs have support for crash dumping. It'd be great if H3 had crash dumping implemented as well.
See https://github.com/envoyproxy/envoy/blob/eda54585c5f63a721f8abf05d1603b7e263f740d/source/common/quic/envoy_quic_client_session.h#L45 and https://github.com/envoyproxy/envoy/blob/eda54585c5f63a721f8abf05d1603b7e263f740d/source/common/quic/envoy_quic_server_session.h#L61 for where to add this support.

The main requirement is that all interaction in the functions are `AsyncSignalSafe`.

[optional *Relevant Links*:]
* See https://github.com/envoyproxy/envoy/issues/14249#issue-755563117 for a brief on crash dumping.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.