envoyproxy / envoyproxy/envoy

TCP Proxy protocol V2 : store data as base64 string

Open
#18,580 1 comment 0 reactions 0 assignees View on GitHub
area/proxy_proto help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

**If you are reporting *any* crash or *any* potential security issue, *do not*
open an issue in this repo. Please report the issue via emailing
envoy-security@googlegroups.com where the issue will be triaged appropriately.**

*Title*: Store TLV data of proxy protocol V2 as base64

*Description*:
Proxy protocol V2 uses binary data for TLV.
When using the tcp proxy filter, we are able to store the tlv data in the metadata as a string.
Since it's binary, it would be more appropriate to store it as base64.
Currently, when we try to log it, we get an error saying it contains invalid characters.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.