envoyproxy / envoyproxy/envoy

Allow custom values of CMAKE_BUILD_TYPE

Open
#17,106 5 comments 0 reactions 0 assignees View on GitHub
area/build enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: *Allow custom values of CMAKE_BUILD_TYPE*

*Description*:
Currently Envoy's build system sets `CMAKE_BUILD_TYPE` to `Bazel` unconditionally (since #8280). Yet some CMake-based dependencies modify e.g. defines or CFLAGS for different build types. The conventional values are `Debug`, `Release`, `RelWithDebInfo` etc.

It would be nice for debug purposes (or for enabling optimizations) to override `CMAKE_BUILD_TYPE` in the `envoy_cmake_external()` rule.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.