envoyproxy / envoyproxy/envoy

Custom clusters do not support endpoint discovery through EDS

Open
#15,663 1 comment 0 reactions 0 assignees View on GitHub
enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: Custom clusters do not support endpoint discovery through EDS

*Description*:
Usage of eds_cluster_config is restricted to clusters that have type explicitly set to `EDS`. Envoy also uses this type for determining whether clusters are initialized during the primary or secondary phase, meaning it is not possible to write a custom cluster type that performs endpoint discovery via EDS.

Instead, I think the custom cluster type should specify whether it utilizes EDS for endpoint discovery, and if so, Envoy should treat it the same way as it does the native EDS cluster (i.e. the cluster is permitted to use `eds_cluster_config`, it is initialized during secondary phase if the config source is not file-based, etc.).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.