envoyproxy / envoyproxy/envoy

Broken Prefix Route Match

Open
#15,592 1 comment 0 reactions 0 assignees View on GitHub
area/docs area/http help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: *Broken Prefix Route Match*

*Description*:
>PrefixRouteEntryImpl::matches used to include (as of 1.13.0) query parameter in the match , now it is excluding the query parameter from match due to this [change](https://github.com/envoyproxy/envoy/blob/main/source/common/router/config_impl.cc#L1066), by this [commit](https://github.com/envoyproxy/envoy/commit/7ea52d5e2b0bccbd3263a805e38778fa132b715d), [here](https://github.com/envoyproxy/envoy/blob/v1.13.0/source/common/router/config_impl.cc#L805) is previous code.

[Documentation](https://www.envoyproxy.io/docs/envoy/v1.17.1/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-routematch) has not changed, wonder if this is intended!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.