envoyproxy / envoyproxy/envoy

Prevent addition of redundant protobuf imports

Open
#15,589 2 comments 0 reactions 1 assignee Claimed by @phlax View on GitHub
area/build help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

### description

we have a lot of redundant import warnings when generating protos

i have raised a pr to fix this upstream in cncf/xds (https://github.com/cncf/xds/pull/3)

i have previously removed them from the envoy codebase (#15329 ) and have just opened another PR to remove more recently added ones (#15588 )

it would be great if we prevented these from being added

the obvious way would be to turn warnings into errors (see https://github.com/protocolbuffers/protobuf/issues/3980)

the problem with this is that there are a lot of warnings about missing dir paths which i think is harder to fix (https://github.com/bazelbuild/bazel/issues/7157)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.