envoyproxy / envoyproxy/envoy

AsyncClientFactory potentially calls ClusterManager::clusters() outside main thread

Open
#15,458 0 comments 0 reactions 0 assignees View on GitHub
area/cluster_manager bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: AsyncClientFactory potentially calls ClusterManager::clusters() outside main thread

*Description*:
An example of this is [grpc access logger](https://github.com/envoyproxy/envoy/blob/40964cc30d4e691df5c5f0c32a449a7b4462115a/source/extensions/access_loggers/common/grpc_access_logger.h#L291).

Another example is a filter implementation similar to [ext_authz](https://github.com/envoyproxy/envoy/blob/40964cc30d4e691df5c5f0c32a449a7b4462115a/source/extensions/filters/http/ext_authz/config.cc#L84..L85) which does not skip static cluster checks (none exist in the open source codebase that I can find).

*Repro steps*:
n/a

*Admin and Stats Output*:
n/a

*Config*:
n/a

*Logs*:
see [comment](https://github.com/envoyproxy/envoy/issues/15447#issuecomment-797071949)

*Call Stack*:
n/a

related: #15447 #15227 #15449

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.