envoyproxy / envoyproxy/envoy

AsyncClientFactory getThreadLocalCluster failure under validation_server

Open
#15,447 9 comments 0 reactions 0 assignees View on GitHub
area/grpc bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

We're seeing an issue validating our grpc access logging config
```
[external/envoy/source/server/config_validation/server.cc:60] error initializing configuration 'generated/config/envoy_canary.yaml': Unknown gRPC client cluster 'grpceventsink'
```

I think these lines should be using the helper `ClusterInfoMaps.getCluster()` instead of iterating the map manually.

https://github.com/envoyproxy/envoy/blob/e20957c011b11a4f9f935ec7556ed89d1d8c22d7/source/common/grpc/async_client_manager_impl.cc#L41-L42

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.