Unify URL parsing with GoogleURL
- Dominant language
- C++
- Stars
- 28.9k
- Forks
- 5.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 437
Description
Two concerns:
* llhttp (http-parser replacement) does not have a URL parser: https://github.com/nodejs/llhttp/issues/7. Derek brought up this concern in that issue.
* The fewer different URL parsing stuff we have, the better.
Envoy uses [http_parser_url]( https://github.com/envoyproxy/envoy/blob/80c0abdc9b4491fa1c35bc20577bb638147cff09/source/common/http/utility.cc#L256) to split the URL into pieces.
We should replace this with GoogleURL, which does URL parsing (https://chromium.googlesource.com/chromium/src/+/master/url#parsing). See
https://chromium.googlesource.com/chromium/src/+/master/url/gurl.h#340
Related Issues:
https://github.com/envoyproxy/envoy/issues/5155
https://github.com/envoyproxy/envoy/issues/6588
Can we bring back https://github.com/envoyproxy/envoy/pull/11670?
cc @derekargueta @dio @envoyproxy/security-team
Contributor guide
Assessment
This issue has not been assessed yet.