Router: Audit ASSERTs
- Dominant language
- C++
- Stars
- 28.9k
- Forks
- 5.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 437
Description
This issue describes a scan of ASSERTs in the router filter and recommendations to change some: https://gist.github.com/asraa/859a41a8f5f252d35da58c9ef7502230
Those marked with a verdict have been audited or unknown if they need a pair of eyes.
- [ ] Change 1 refactorable call https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L276 add check for scheme headers during filter processing https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L566
- [ ] Audit
* https://github.com/envoyproxy/envoy/blob/488973532ac72f56473bd2b6f770f0a011bf14a1/source/common/router/router.cc#L653
Contributor guide
Assessment
This issue has not been assessed yet.