HTTP/2 codec: Audit ASSERTs
- Dominant language
- C++
- Stars
- 28.9k
- Forks
- 5.6k
- Avg merge
- 1d 20h
- Merged PRs (30d)
- 437
Description
This issue describes a scan of ASSERTs in the HTTP/2 codec and recommendations to change some: https://gist.github.com/asraa/eb8b90a6398d202dd584cf403e3c6f3a
Those marked with a verdict have been audited or unknown if they need a pair of eyes.
- [ ] Change 1 potentially triggerable condition https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L223 and one nghttp2 return code https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L387
- [ ] Audit unknowns:
* https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L391
* https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L750
* https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L773
* https://github.com/envoyproxy/envoy/blob/d5e8634edf26dab65218e42f2acfe7c3dc95b72d/source/common/http/http2/codec_impl.cc#L1085
Contributor guide
Assessment
This issue has not been assessed yet.