envoyproxy / envoyproxy/envoy

[xds] ADS reject duplicate resources in grpc_mux

Open
#14,847 8 comments 0 reactions 0 assignees View on GitHub
area/xds bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: in grpc_mux_impl, let's reject a resonse when we see duplicate resources.

*Description*:
see https://github.com/envoyproxy/envoy/blob/main/source/common/config/grpc_mux_impl.cc#L224
We want to not "dedup" but reject the response here when the emplace fails

new_grpc_mux_impl seems doesnt have same issue as it push dup resources to each xds impl, where the dup resources gets rejected.

*Repro steps*:
> send a discoveryResponse with multiple resources with the same name. Envoy accepts it silently.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.