envoyproxy / envoyproxy/envoy

HTTP health check filter depends on stats

Open
#14,610 10 comments 0 reactions 1 assignee Claimed by @yanavlasov View on GitHub
area/health_checking area/stats bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Title*: *HTTP health check filter depends on stats*

*Description*:
The [HTTP health check filter](https://github.com/envoyproxy/envoy/blob/d7b10e8d1e782e7284e2cb7e4a83b6525b6a8f05/source/extensions/filters/http/health_check/health_check.cc#L146-L166) relies on the presence of the following stats: `membership_total`, `membership_healthy`, and `membership_degraded`. Running a configuration that filters out these stats will cause the filter to not work properly. Like #9856, this falls into the category of using stats for control flow.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.