envoyproxy / envoyproxy/envoy

stats: allow pre-defined tags

Open
#14,071 7 comments 0 reactions 0 assignees View on GitHub
area/stats help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

The internal API to create tags has two versions:
1. Create from qualified stat name.
2. Create from stat name plus a set of tags.

We'd like to have a third version:
1. Create from stat name plus a set of tag names. Tag names match against the content of the stat to obtain values. For example, stat "a.b.c" with tag names "d.e" produces "a{d=b,e=c}". Here the separator is a dot, but could be any special character.

The benefit is two-fold:
1. Save on space, instead of "a.d.b.e.c" we can share "d" and "e" symbols between stat names with different tag values.
2. Simplify user experience by not required regexes to achieve the same effect.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.