envoyproxy / envoyproxy/envoy

stats: prevent disabling some stats

Open
#14,051 3 comments 1 reaction 1 assignee Claimed by @jmarantz View on GitHub
area/stats enhancement no stalebot
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Description*:
>Some stats can potentially be used for functional purposes during operation. However, the fact that they can be disabled via a stats matcher expression makes that an anti-pattern currently. We should have a mechanism to mark a stat as being immune from disabling. Since the disabling happens during stat instantiation, this would need to occur during stat construction.

*Relevant Links*:
> https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/metrics/v3/stats.proto#config-metrics-v3-statsmatcher

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.