envoyproxy / envoyproxy/envoy

feature: Cluster level HTTP health check port setting

Open
#14,045 9 comments 2 reactions 0 assignees View on GitHub
area/health_checking help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Description*:
There's currently a configuration option within [config.endpoint.v3.Endpoint.HealthCheckConfig](https://www.envoyproxy.io/docs/envoy/v1.16.0/api-v3/config/endpoint/v3/endpoint_components.proto.html) for overriding the `port_value`.

The issue with this, or rather, the inconvenience, is that this is configurable per-endpoint. Ideally, we'd have the ability to configure this also at the cluster [config.core.v3.HealthCheck](https://www.envoyproxy.io/docs/envoy/v1.16.0/api-v3/config/core/v3/health_check.proto#config-core-v3-healthcheck) level as well, with the current setting operating as an override if there is no cluster level setting set. This would work (assumingly) identical to the `hostname` value inside of the `HealthCheckConfig` today based on it's documentation:

> By default, the host header for L7 health checks is controlled by cluster level configuration (see: host and authority). Setting this to a non-empty value allows overriding the cluster level configuration for a specific endpoint.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.