envoyproxy / envoyproxy/envoy

DNS config: validate mutually exclusive options when loading dns config.

Open
#13,512 0 comments 0 reactions 0 assignees View on GitHub
area/dns help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

#13074 added a config option that is mutually exclusive with the existing (resolvers, using tcp for resolution) dns config options. Currently using these options together results in a release assert being triggered.

This issue tracks adding a centralized config validation function that always runs on the main thread. This way the validation can safely throw an exception. When this validation is added the release assert in `createDnsResolver` can be deleted.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.