envoyproxy / envoyproxy/envoy

thread_local: thread safety follow ups

Open
#13,313 1 comment 0 reactions 1 assignee Assigned to @jmarantz View on GitHub
area/thread_local help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

A couple of follow ups to https://github.com/envoyproxy/envoy/pull/12833:

1) Try to make the API a bit cleaner with templating: https://github.com/envoyproxy/envoy/pull/12833#discussion_r496594468
2) Build clang-tidy plugin to check for any TLS functions capturing "this", and fix all current examples. (There are several that capture "this" in the initial set() call, and some that have been "fixed" to use shared_from_this and weak_ptr.)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.