envoyproxy / envoyproxy/envoy

Windows CI: Do not pass Linux specific options for ENVOY_DOCKER_OPTIONS in pipeline

Open
#13,272 5 comments 0 reactions 0 assignees View on GitHub
area/build help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

In https://github.com/envoyproxy/envoy/pull/13222 we collapsed the original Windows specific script to run an Envoy build in Docker into the Linux one. We found that the CI pipelines pass a Linux specific value for `ENVOY_DOCKER_OPTIONS` which of course are invalid for Windows.

We would like to be able to use the same mechanism `ENVOY_DOCKER_OPTIONS` for overriding options in Docker on Windows (for a uniform developer experience to allow CI/local builds to add options, particularly `--storage-opt` to allow for much larger disk space).

Currently `ENVOY_DOCKER_OPTIONS` is ignored on Windows to accommodate CI, but if we can change the variable groups in CI to not pass the Linux specific options to Windows, we can stop ignoring the variable.

The action item in this issue is to see if we can modify how Azure Pipelines is set up to run the various CI jobs so we can pass an empty/non-Linux specific value for the `ENVOY_DOCKER_OPTIONS` variable. This will enable us to add back the support for `ENVOY_DOCKER_OPTIONS` as a variable that can be used as part of the `run_envoy_docker.sh` script to modify how Docker is invoked.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.