envoyproxy / envoyproxy/envoy

requests failed "above" EDS level should be reflected in load reporting

Open
#13,206 1 comment 0 reactions 0 assignees View on GitHub
area/cluster_manager bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

There are at least a couple of cases where Envoy will fail requests "above" the EDS layer:

- When the EDS resource does not exist.
- When the cluster fails requests due to [maintenance mode](https://www.envoyproxy.io/docs/envoy/latest/configuration/http/http_filters/router_filter.html?highlight=maintenance%20mode#runtime).

In these cases, the failed requests don't show up in LRS load reporting at all. I think this should be changed to report these as failed requests in an [UpstreamLocalityStats](https://github.com/envoyproxy/envoy/blob/7aec38f986aa6b74ec04865ebc2264d599f1ba94/api/envoy/config/endpoint/v3/load_report.proto#L26) message that does not have the locality field populated. This representation seems compatible with how we report stats for non-EDS clusters (e.g., LOGICAL_DNS clusters).

CC @htuch

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.