envoyproxy / envoyproxy/envoy

access log: add a new response flag to indicate request handled locally by Envoy

Open
#13,100 5 comments 0 reactions 0 assignees View on GitHub
area/access_log enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: access log: add a new response flag to indicate request handled locally by Envoy

*Description*:
This is started from the discussion in https://github.com/envoyproxy/envoy/pull/12912#discussion_r490613876 that we could have a more general way to indicate that the request is handled locally by Envoy (sendLocalReply) instead of by upstream.

The response flag could be `RESPONDED_BY_FILTER` and deprecates the other `response_from_cache_filter`. The `RESPONSE_CODE_DETAIL` can be used to learn more details.

cc @htuch

[optional *Relevant Links*:]
>Any extra documentation required to understand the issue.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.