envoyproxy / envoyproxy/envoy

Update observability dependency libcircllhist

Open
#12,804 0 comments 0 reactions 0 assignees View on GitHub
dependencies help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
428

Description

*Title*: *Update observability dependency `libcircllhist`*

*Description*:
When trying to update the observability dependencies in https://github.com/envoyproxy/envoy/pull/12799 the latest `libcircllhist` the following tests fail with not returning expected results.

- envoy/bazel-out/k8-fastbuild/testlogs/test/common/stats/thread_local_store_test/test.log
- envoy/bazel-out/k8-fastbuild/testlogs/test/extensions/stats_sinks/hystrix/hystrix_test/test.log
- envoy/bazel-out/k8-fastbuild/testlogs/test/server/admin/prometheus_stats_test/test.log
- envoy/bazel-out/k8-fastbuild/testlogs/test/server/admin/stats_handler_test/test.log

I lost the detailed logs with subsequent commits but will try to reproduce

*Relevant Links*:
The commits / changes between the lastest June 25 2020 commit and the current Envoy commit on February 11 2019 is https://github.com/circonus-labs/libcircllhist/compare/63a16dd6f2fc7bc841bb17ff92be8318df60e2e1...18f1b97603757d5e65baefa65b90d6ec182e8a30

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.