envoyproxy / envoyproxy/envoy

Clean up proliferation of std::chrono duration types

Open
#12,384 3 comments 0 reactions 0 assignees View on GitHub
help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

https://github.com/envoyproxy/envoy/pull/12225 ensured that arbitrary `std::chrono::{clock_type}::duration` constructors cannot be used as it introduces differences in time representation/units between different platforms. @lizan suggested also ensuring that `TimeSystem` (used in test infrastructure) should provide a concrete duration type to reduce the proliferation of `std::chrono` duration types. Concrete duration aliases were added in that class but all usages of `std::chrono` duration types are not yet converted to `TimeSystem::Nanosecond` etc.

This issue is a placeholder to denote that `std::chrono` duration types should be replaced with `TimeSystem` aliases and introduce a format check to prevent their re-addition in the future.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.