envoyproxy / envoyproxy/envoy

Exception caused by RTDS misconfiguration not caught by validation server

Open
#12,161 0 comments 0 reactions 0 assignees View on GitHub
area/runtime bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

We saw a case in which a misconfiguration at the RTDS layer was not caught by the validation server. In staging (running the server in its normal mode) Envoy crashed with the following exception as expected:

`EnvoyException in c-ares callback: envoy.config.core.v3.ApiConfigSource must have a statically defined non-EDS cluster: 'someclustername' does not exist, was added via api, or is an EDS cluster`

Ideally this sort of error could be caught in development via running Envoy in validation mode. I've not looked too much into the validation server yet but the exception is thrown after `starting main dispatch loop`, which I noticed is not part of the validation process today based on the logs I'm seeing.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.