envoyproxy / envoyproxy/envoy

Repeated on-demand vhds updates unsubscribe from previously resolved vhosts

Open
#12,158 4 comments 0 reactions 1 assignee Claimed by @dmitri-d View on GitHub
area/xds bug help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Description:
If a vhost named "foo.com" has been previously resolved, an attempt to resolve "bar.com" will result in "foo.com" vhost being unsubscribed from, and all updates for it lost.

This is due to how `GrpcMuxWatch::update` is implemented -- it expects a list of resource names that should be watched. The resources which names are not in the list will be unsubscribed from.

edit: not an issue for NewGrpcMuxImpl::addWatch

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.