envoyproxy / envoyproxy/envoy

subset lb: support customized response code when using NO_FALLBACK

Open
#11,983 1 comment 0 reactions 0 assignees View on GitHub
area/load balancing design proposal help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

We have a use case for the subset LB in which we'd like to return a 404 when there is no metadata/subset match. Right now, a 503 (no healthy hosts) response is the only possible response:

https://github.com/envoyproxy/envoy/blob/master/api/envoy/config/cluster/v3/cluster.proto#L206

We could make this knob something specific to the subset LB; or we could make it something generic for all LBs similar to `ClusterNotFoundResponseCode` (e.g.: `EndpointNotFoundResponseCode`):

https://github.com/envoyproxy/envoy/blob/master/api/envoy/config/route/v3/route_components.proto#L794

Thoughts?

cc: @zuercher @fishcakez @janephilipps @mattklein123

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.