envoyproxy / envoyproxy/envoy

Redis Health Checks do not support ACL auth_username

Open
#11,736 0 comments 0 reactions 0 assignees View on GitHub
area/redis help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Title: Redis Health Checks do not support the Redis 6 ACL auth_username parameter

Description:

The only thing I was not able to handle in the previous PR #11408 is supporting auth_username for health checks. This is ok for our initial use case as we can grant the default user +ping permissions. That said, others might like this feature and I am happy to work on it.

https://github.com/envoyproxy/envoy/blob/master/source/extensions/health_checkers/redis/redis.cc#L4 is still using API V2 configuration for health checks and so I was not able to add auth_username to the proto or the impl.

I propose adding a V3 API for redis health checks that supports auth_username and make the associated changes, but I wanted to check with you on this approach before starting the work.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.