envoyproxy / envoyproxy/envoy

router check tool: support coverage for routes with runtime set to 100%

Open
#11,502 0 comments 0 reactions 0 assignees View on GitHub
area/route_check_tool help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

The router check tool tests for runtime by treating the runtime setting as enabled when the `random_value` field is less than the fractional percentage set in the default fraction for the runtime field. To account for when the numerator was 0 (i.e. runtime disabled by default), the tool treats the route as though the numerator is 1 so that users can test for coverage.

A similar workaround needs to be implemented for runtime fractions of 100% (i.e. when the route has runtime enabled by default).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.