envoyproxy / envoyproxy/envoy

memory safety: audit use of static variables

Open
#11,130 5 comments 0 reactions 1 assignee Claimed by @lizan View on GitHub
help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

We should audit the use of static variables in the codebase to prevent static initialization/deinitialization order problems internally, and for [dependent projects](https://github.com/lyft/envoy-mobile/issues/688#issuecomment-625954485).

The codebase already defines a construct on first use [macro](https://github.com/envoyproxy/envoy/blob/1210df904254d8144cd7c35106df091aceb5375a/source/common/common/macros.h#L32). We should audit other static variables that should be migrated, and enforce the pattern via code linting.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.