envoyproxy / envoyproxy/envoy

Mock stat objects should reuse logic for combining stat name and tags into a full stat name

Open
#10,946 0 comments 0 reactions 0 assignees View on GitHub
area/stats help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

The mock stat objects allow setting `name`, `tag_extracted_name` and `tags` independently, while real stats will have a `name` that is is a function of the given name and the provided tags. This discrepancy makes it hard to verify behavior that relies on this invariant.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.