envoyproxy / envoyproxy/envoy

retries: Make retry budgets default

Open
#10,869 0 comments 0 reactions 0 assignees View on GitHub
area/retry help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

Currently, the `max_retries` circuit breaker is set to a static value of 3 by default. [Retry budgets](https://www.envoyproxy.io/docs/envoy/latest/api-v2/api/v2/cluster/circuit_breaker.proto#envoy-api-msg-cluster-circuitbreakers-thresholds-retrybudget) enable a better way to protect against retry storms that scales with the number of active requests.

One may have the same behavior as the static `max_retries` circuit breaker using retry budgets by setting the percentage to 0% and a minimum retry concurrency of the desired static value, so it might also be worth discussing whether the `max_retries` circuit breaker could be deprecated.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.