envoyproxy / envoyproxy/envoy

RTDS snapshot should be pinned to each stream

Open
#10,731 1 comment 0 reactions 0 assignees View on GitHub
area/runtime help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: we should keep runtime's consistency during a request's lifecycle.

*Description*:
runtime layers should be consistent during processing of a request.

*Repro steps*:
> a bug scenario:
filter A reads version 1 of runtime snapshot, filter A stopIteration, waits for a some callback result, say on-demand-rds
a new Runtime snapshot (version 2) is pushed by RTDS,
filter A resume the filter iteration, and filter B now sees version 2 when it reads from loader.runtime().snapshot()

IMO, We should latch the runtime snapshot to a stream during its creation time.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.