envoyproxy / envoyproxy/envoy

Returning the correct code when per_try_timeout budget is exhausted

Open
#10,574 2 comments 0 reactions 0 assignees View on GitHub
area/grpc enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 20h
Merged PRs (30d)
437

Description

*Title*: Returning the correct code when per_try_timeout budget is exhausted

*Description*:
If a `per_try_timeout` budget is exhausted, the returned code is 503. This is arguably correct for HTTP1 but for gRPC communication a `deadline-exceeded` (setting `grpc-status` to `4`) would be more accurate.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.