envoyproxy / envoyproxy/envoy

Deprecate Http2ProtocolOptions.allow_connect

Open
#10,412 0 comments 0 reactions 0 assignees View on GitHub
area/http help wanted tech debt
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

PR #9964 introduced user defined HTTP/2 SETTINGS parameters and disallowed overriding "named" parameters (e.g., `hpack_table_size`) with these custom parameters. However, an exception had to be made for [`allow_connect`](https://github.com/envoyproxy/envoy/blob/1db15db60af37b167b72e3c5e653ffdda9711336/api/envoy/api/v2/core/protocol.proto#L153), a field for which presence can't be checked due to the use of a scalar type.

An API change must be introduced to remove the exception and enable uniformity in override handling.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.