envoyproxy / envoyproxy/envoy

api_listener: allow the api listener to configure settings for the synthetic connection

Open
#10,291 0 comments 0 reactions 0 assignees View on GitHub
area/connection area/listener enhancement help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

*Description*:
Right now the SyntheticConnection used inside the Api Listener is not configurable. For instance there is no way to change the return value of the [ssl()](https://github.com/envoyproxy/envoy/blob/9105aead0f5c89419bd2aca789b3738967c0baa1/source/server/api_listener_impl.h#L117) call. This can have implications in the requests that are created by the Api Listener. For instance, for the example above the value returned by that function dictates the value added for the `x-forwarded-proto` header [here](https://github.com/envoyproxy/envoy/blob/9105aead0f5c89419bd2aca789b3738967c0baa1/source/common/http/conn_manager_utility.cc#L134). Therefore, it might be valuable to allow the Api Listener to specify things about its Synthetic Connection.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.