envoyproxy / envoyproxy/envoy

Hot restart support for user defined tags

Open
#10,264 0 comments 1 reaction 0 assignees View on GitHub
area/stats help wanted
Dominant language
C++
Stars
28.9k
Forks
5.6k
Avg merge
1d 22h
Merged PRs (30d)
430

Description

After https://github.com/envoyproxy/envoy/pull/9743 we support specifying tags on metric creation, but there is no mechanism to populate the tags for metrics object after a hot restart. The full name (with the tag key-values included) would be transferred over, but without knowing how to split the name this would become the new stat name, and no tags would be moved over.

One possibility would be to insert a sentinel value in front of each key and value so that we can extract out the key/values during the stat merger:
```
stat.name.TAG_KEY.some.key.TAG_VALUE.some.value
```
would represent the stat `stat.name` with a single tag `some.key = some.value`

Another option would be to pass more than just a string during the hot restart, but iirc that would require changing the hot restart RPC proto, which might require bumping the hot restart version?

@jmarantz

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.