envoyproxy / envoyproxy/envoy-mobile

ios/android: expose connectivity errors via EnvoyError enumerated code

Open
#585 1 comment 0 reactions 0 assignees View on GitHub
help wanted no stalebot platform/android platform/ios
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

When requests time out due to network connectivity or being offline entirely, Envoy Mobile currently calls `onError` with an `EnvoyError` containing a `0` status code and `upstream request timeout` message.

In order to better communicate _which error_ occurred to end consumers, we can replace the `code` with an enumeration containing human-readable error reasons.

For example:

```swift
enum EnvoyErrorCode: Int {
case unknown = 0
case upstreamTimeout = 1
case dnsFailure = 2
...
}
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.