envoyproxy / envoyproxy/envoy-mobile
ios bridge: minimize buffer copies
Open
no stalebot
perf
platform/ios
- Dominant language
- Java
- Stars
- 566
- Forks
- 85
- PR merge metrics
- No merged PRs in 30d
Description
Currently the bridging code between iOS and Envoy is [copying NSData](https://github.com/lyft/envoy-mobile/blob/67db8c4c964e6bdec53fd1e12081beed30f109e3/library/objective-c/EnvoyHTTPStream.m#L17) contents over to uint8_t buffers on the forward direction, and likewise on the callbacks.
Given Envoy's powerful UnownedSlices for Buffers we can minimize the forward copies by creating envoy_data backed by the memory created by NSData, similar to how we do so in Java.
Contributor guide
Assessment
This issue has not been assessed yet.