envoyproxy / envoyproxy/envoy-mobile

TestConfig.StringAccessors seems to be flaky

Open
#2,641 0 comments 0 reactions 1 assignee Claimed by @RyanTheOptimist View on GitHub
area/testing
Dominant language
Java
Stars
566
Forks
85
PR merge metrics
No merged PRs in 30d

Description

TestConfig.StringAccessors seems to be flaky, or at least fragile. I got a test failure in an unrelated PR recently:

[2022-10-31 13:02:05.770][13641667][critical][assert] [external/envoy/test/test_listener.cc:21] assert failure: !Thread::MainThread::isMainThreadActive(). Details: MainThreadLeak: [TestConfig.StringAccessors] test exited before main thread shut down

https://github.com/envoyproxy/envoy-mobile/actions/runs/3322946043/jobs/5571794275

Doing some local testing, I noticed that if I re-order the tests in envoy_config_test.cc so that this test does not run last, then it causes failures reliably.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.